-
Notifications
You must be signed in to change notification settings - Fork 84
Fix for newer GM65 Scanners scanning CompactSeedQR + Add "About Screen" #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for specter-diy-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Is this still relevant? @Schnuartz |
|
This automatically applied the fix that the QR code manually appliesv that makes the newer ones work |
*Add version check and set RAW mode for readers that need this *Report detected scanner SW version on the QR scanner screen
|
I tested it myself. And it did not work for me. The new GM65 Scanner still had the same problem with Compact SeedQRs. (I downloaded the testing-firmware here: Firmware Hash: sha256:1dd8feb0085136bd20a64786bf706d01c59a8849df48d48668462356bcf0803e |
…sion-screen-ftc741 Embed git metadata during firmware builds and surface it in settings
…out-screens Adjust settings note and include build metadata in About screen
…1-flag Display boot mode and flash protection in about screen
…s-application Ensure QR scanner RAW fix persists automatically
…on-to-qr-settings Add QR scanner factory reset and info display
|
@Schnuartz please check again! |


*Add version check and set RAW mode for readers that need this
*Report detected scanner SW version on the QR scanner screen
*Some extra formatting stuff that PyCharm added (Spaces between operators)
Rather than just applying the fix to all readers, I have left it to only be applied to those that we know need it. The fix basically involves writing a magic number to an undocumented memory register and while this doesn't seem to have negative consequences for older readers, it's probably best to avoid it if not needed... (And it also seems that the really new GM65 devices have resolved this issue...) See #288 (comment)
The patch also adds a small note at the tope of the QR scanner screen that reports the detected reader software version as an integer.
The only question for me is whether the ability to toggle RAW mode on and off could be useful for folk who may have been using the affected readers without realizing or checking the seed words, but I'm thinking that is likely to cause more issues than it solves if part of the mainline builds... (If it comes up, then something like this could be added as part of some "Advanced" menu with a bunch of warnings)